Skip to content

pypi compatibility#649

Open
cmunley1 wants to merge 6 commits intomainfrom
cmunley1/pypi-compat
Open

pypi compatibility#649
cmunley1 wants to merge 6 commits intomainfrom
cmunley1/pypi-compat

Conversation

@cmunley1
Copy link
Contributor

@cmunley1 cmunley1 commented Feb 5, 2026

  • search cwd for env.yaml and for config paths provided to ng_run.
  • use importlib.metadata for ng_help

along with these changes, if I change paths (ie ../../) in servers' requirements.txt / pyproject.toml to absolute paths (or i suppose to the pypi package itself once its published), i can run both existing environments in Gym/, and new environments that I create myself, assuming I respect the Gym directory structure in my local environment (e.g. resources_server/myserver/configs/myconfig.yaml)

basic tests done of ng_run and ng_collect_rollouts with a single environment, both one in Gym/ today, and a new one I make outside of Gym. need to test everything else too. also tested ng_help with this fix.

I think that we should really consider a few things, but maybe we stick to minimal changes for now:

  • packaging environments separately
  • moving resources_servers etc inside nemo_gym to have only 1 entrypoint in sitepackages, i find it strange to have site-packages/resources_servers
  • giving user clear guidance on proper way to make new env with pip installed gym. Mocking Gym repo structure is 1 option

Signed-off-by: Christian Munley <cmunley@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 5, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cmunley1 cmunley1 requested a review from bxyu-nvidia February 5, 2026 07:21
Signed-off-by: Christian Munley <cmunley@nvidia.com>
@cmunley1 cmunley1 marked this pull request as ready for review February 6, 2026 02:29
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant