Open
Conversation
Signed-off-by: Christian Munley <cmunley@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Christian Munley <cmunley@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
env.yamland for config paths provided tong_run.importlib.metadataforng_helpalong with these changes, if I change paths (ie ../../) in servers' requirements.txt / pyproject.toml to absolute paths (or i suppose to the pypi package itself once its published), i can run both existing environments in Gym/, and new environments that I create myself, assuming I respect the Gym directory structure in my local environment (e.g.
resources_server/myserver/configs/myconfig.yaml)basic tests done of
ng_runandng_collect_rolloutswith a single environment, both one inGym/today, and a new one I make outside of Gym. need to test everything else too. also testedng_helpwith this fix.I think that we should really consider a few things, but maybe we stick to minimal changes for now:
site-packages/resources_servers